Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: relax version reqs on thiserror and derive-new #130

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

govinda-kamath
Copy link
Contributor

  • strict version requirements there cause issues when updating downstream with other libraries (like rust-htslib)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11825427215

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 63.265%

Totals Coverage Status
Change from base Build 10367664932: 0.0%
Covered Lines: 465
Relevant Lines: 735

💛 - Coveralls

@sjackman
Copy link
Contributor

@dlaehnemann Hi, David! Thank you for all of your work on Rust-Bio! Could you please merge this PR as well as the open Dependabot PRs? It's helpful to downstream projects to keep the dependencies of rust-bio and rust-bio-type in sync.

@pmarks pmarks self-requested a review January 23, 2025 12:16
Copy link
Contributor

@pmarks pmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@pmarks pmarks merged commit e502e1b into rust-bio:master Jan 23, 2025
8 checks passed
@govinda-kamath govinda-kamath deleted the patch-1 branch January 23, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants