chore: allow using bitcoin_hashes v0.14
#82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears to be API-compatible for the purposes of this crate, so there should be no harm in allowing it and will help others projects deduplicate dependencies.
|
Duplicate of #76 (note that I did that in July), and the reason its not been merged is becaue of #79 - MSRV issues. I talked with @stevenroose offline yonks ago and he indicated at that time that he did not want to bump the MSRV of this crate because some users were using this crate on bare metal and the MSRV bump would be a PITA (IIRC, it was well over six months ago). I do not know his current position on the topic. |
|
Thx for the explanation and sorry for not checking 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears to be API-compatible for the purposes of this crate, so there should be no harm in allowing it and will help others projects deduplicate dependencies.
I also tested 0.15 and that lead to errors.
What are your thoughts on a 0.2.2 release if we can land this? Should I just include a version bump+changelog entry in the PR as a separate commit?