Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iterable run method #296

Merged
merged 23 commits into from
Jan 3, 2024
Merged

Iterable run method #296

merged 23 commits into from
Jan 3, 2024

Conversation

superstator
Copy link
Contributor

alternative to #293 w/o a runner-held connection handle

  • adds run_stepwise() method returning an iterator over migrations
  • refactors some migration code to reduce duplication between sync/async implementations and make handling of Target::Fake more consistent

@jxs
Copy link
Member

jxs commented Dec 11, 2023 •
edited
Loading

thanks! ❤️ I assume it's still a Draft right? feel free to ping me directly when it's ready for a review.

@superstator
Copy link
Contributor Author

Yeah, I just wanted to add a few tests before I called it ready.

@superstator superstator marked this pull request as ready for review December 12, 2023 19:25
@superstator
Copy link
Contributor Author

@jxs just lmk if there's anything else you're concerned about here

jxs
jxs reviewed Dec 24, 2023
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this! ❤️ left a couple minor comments

refinery_core/src/runner.rs Outdated Show resolved Hide resolved
refinery_core/src/runner.rs Outdated Show resolved Hide resolved
examples/main.rs Outdated Show resolved Hide resolved
refinery_core/src/runner.rs Outdated Show resolved Hide resolved
refinery_core/src/traits/sync.rs Outdated Show resolved Hide resolved
refinery_core/src/traits/sync.rs Outdated Show resolved Hide resolved
@jxs jxs mentioned this pull request Dec 25, 2023
Merged
jxs
jxs approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! Only one minor comment left

examples/main.rs Outdated Show resolved Hide resolved
@jxs jxs merged commit 17162c1 into rust-db:main Jan 3, 2024
27 checks passed
@jxs
Copy link
Member

jxs commented Jan 3, 2024

Thanks for this, and the patience for the review! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@superstator @jxs