Add support for quoted arguments containing spaces #13
Conversation
|
Opinions on this @thejpster? |
|
I haven't opened the diff yet but the reason I didn't do this is so I could always sub slice the input buffer. If you have to trim escaping backslashes then you can't. Or rather, you have to mutate the input buffer to trim the escapes. So, not impossible, but it required extra work. Ok, let me go look! |
| argument_count += 1; | ||
| if arg.starts_with("--") { | ||
| // buffer of characters and lengths | ||
| let mut buf = [([0u8; 32], 0_usize); 16]; |
There was a problem hiding this comment.
32 x 16 bytes is quite a big increase of memory usage compared to what we had before.
If this remains it should be a const generic.
There was a problem hiding this comment.
Or it might be better to de-escape the buffer in place. Any de-escaped string must be the same length or shorter than the input string, and so that should always fit into the buffer that's available.
|
Another option could be a Raw parameter type, which just gives everything to the handler as one long string. The handler can then do its own parsing and de-escaping. |
Hello,
I'd like to add support for quoted arguments that contain spaces. Please feel free to suggest improvements, it's not exactly a pretty change. Rebuilding the arguments character by character from
[u8; 32]is maybe a limiting approach. Anyways suggestions are welcome.The current result of the main branch is this:
The result under the changes of this pull request is this:
