-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add emoji to log level name for iOS #108
Conversation
This seems like something an individual logging implementation should do, not the base log crate. This will also break parsing since |
@sfackler Yeah, agree. Do you think https://github.com/sfackler/log4rs/blob/master/src/encode/pattern/mod.rs#L553 please also check this estk/log4rs#44 😄 |
because we can't tweak Xcode 8 to use color in console emoji is a viable workaround, and log implementaion could use this. robbiehanson/XcodeColors#88
Updated, only add method to get emoji. |
How standard are these choices of emoji? |
It is compatible with https://github.com/SwiftyBeaver/SwiftyBeaver |
This doesn't need to be provided in As far as I can tell there isn't a standard but ❌ |
Just a heads up, if you use this in your logging in Xcode you'll get some pretty buggy behaviors trying to use debugger commands as well as some pretty serious performance hits on the logging since Xcode's console text layout engine doesn't seem to like rendering emoji with fixed width fonts. One bug that's really annoying with this is the autocomplete menus keep flickering and disappearing when using emojis in logging statements. We ended up removing them from our implementation it was so bad, but YMMV. |
because we can't tweak Xcode 8 to use color in console
robbiehanson/XcodeColors#88