-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update destructors.md #1471
base: master
Are you sure you want to change the base?
Update destructors.md #1471
Conversation
CC: @mbrubeck |
CC; @ehuss |
Oops this will need to be fixed up. |
@@ -104,6 +104,26 @@ dropped last when evaluating the function. Each actual function parameter is | |||
dropped after any bindings introduced in that parameter's pattern. | |||
|
|||
```rust | |||
// entire function scope begins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First letter should be capitalized unless it's an identifier
, for correctness and consistency with other Rust documentation (including this file). Ditto for all the other comments.
We're discussing this in the rustdocs call. We're a bit unclear on the motivation for this change. If you could describe here in more detail what should be changed here, why, and why the change proposed is the right way to address it, that would be helpful. Also, we note that the PR should be rebased and squashed. |
Based on QA examples provided here: https://users.rust-lang.org/t/why-the-parameter-of-a-function-is-droped-afer-the-temporary-variable-in-return-of-the-function/106430/4