Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump rustc-perf submodule #135292

Merged
merged 1 commit into from
Jan 11, 2025
Merged

bump rustc-perf submodule #135292

merged 1 commit into from
Jan 11, 2025

Conversation

lqd
Copy link
Member

@lqd lqd commented Jan 9, 2025

This updates the rustc-perf submodule to pull in the recent changes, in particular the error handling in rust-lang/rustc-perf#2021 fixing the error we saw in a recent run.

I think I did this correctly, submodules are so annoying.

r? kobzol

(opening as draft to do a perf run and check that nothing has changed indeed)

in particular to get the new benchmark error handling
@rustbot
Copy link
Collaborator

rustbot commented Jan 9, 2025

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 9, 2025
@lqd
Copy link
Member Author

lqd commented Jan 9, 2025

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 9, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 9, 2025
bump `rustc-perf` submodule

This updates the `rustc-perf` submodule to pull in the recent changes, in particular the error handling in rust-lang/rustc-perf#2021 fixing the error we saw in a recent run.

I think I did this correctly, submodules are so annoying.

r? kobzol

(opening as draft to do a perf run and check that nothing has changed indeed)
@bors
Copy link
Contributor

bors commented Jan 9, 2025

⌛ Trying commit 958a772 with merge 142e90b...

@bors
Copy link
Contributor

bors commented Jan 9, 2025

☀️ Try build successful - checks-actions
Build commit: 142e90b (142e90b6d5834da42baaf84631409b68ca8af4c2)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (142e90b): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.1% [1.1%, 1.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary -2.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.3% [-2.3%, -2.3%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 763.48s -> 763.509s (0.00%)
Artifact size: 325.77 MiB -> 325.74 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 9, 2025
@Kobzol
Copy link
Contributor

Kobzol commented Jan 10, 2025

Looks good, including perf. You can r=me.

@lqd lqd marked this pull request as ready for review January 10, 2025 10:56
@lqd
Copy link
Member Author

lqd commented Jan 10, 2025

Great, thank you. Let's keep this as rollup=never for bisections or CI failures in opt-dist.

@bors r=kobzol

@bors
Copy link
Contributor

bors commented Jan 10, 2025

📌 Commit 958a772 has been approved by kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2025
@bors
Copy link
Contributor

bors commented Jan 11, 2025

⌛ Testing commit 958a772 with merge fb65a3e...

@bors
Copy link
Contributor

bors commented Jan 11, 2025

☀️ Test successful - checks-actions
Approved by: kobzol
Pushing fb65a3e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 11, 2025
@bors bors merged commit fb65a3e into rust-lang:master Jan 11, 2025
7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 11, 2025
@lqd lqd deleted the rustcperfup branch January 11, 2025 15:44
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (fb65a3e): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.6% [1.1%, 4.1%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.6% [1.1%, 4.1%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 762.986s -> 763.38s (0.05%)
Artifact size: 326.03 MiB -> 326.03 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants