Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bare-fn-no-impl-fn-ptr-99875 test less dependent on path width #135294

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

ChrisDenton
Copy link
Member

This sets diagnostic-width to some arbitrary number. Seems to work on my machine.

@rustbot
Copy link
Collaborator

rustbot commented Jan 9, 2025

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 9, 2025
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah seems to work for me locally too, thanks!

@jieyouxu jieyouxu assigned jieyouxu and unassigned oli-obk Jan 9, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Jan 9, 2025

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 9, 2025

📌 Commit 00448ab has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2025
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jan 10, 2025
Make `bare-fn-no-impl-fn-ptr-99875` test less dependent on path width

This sets diagnostic-width to some arbitrary number. Seems to work on my machine.
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 10, 2025
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#133088 (`-Zrandomize-layout` harder. `Foo<T> != Foo<U>`)
 - rust-lang#134619 (Improve prose around `as_slice` example of IterMut)
 - rust-lang#134855 (Add `default_field_values` entry to unstable book)
 - rust-lang#134908 (Fix `ptr::from_ref` documentation example comment)
 - rust-lang#135275 (Add Pin::as_deref_mut to 1.84 relnotes)
 - rust-lang#135294 (Make `bare-fn-no-impl-fn-ptr-99875` test less dependent on path width)
 - rust-lang#135304 (Add tests cases from review of rust-lang#132289)
 - rust-lang#135308 (Make sure to walk into nested const blocks in `RegionResolutionVisitor`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit efc2523 into rust-lang:master Jan 10, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 10, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 10, 2025
Rollup merge of rust-lang#135294 - ChrisDenton:bare-fn-width, r=jieyouxu

Make `bare-fn-no-impl-fn-ptr-99875` test less dependent on path width

This sets diagnostic-width to some arbitrary number. Seems to work on my machine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants