[mir-opt] simplify Repeats that don't actually repeat the operand
#135322
+102
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Nadrieril rustbot has assigned @Nadrieril. Use |
rustbot
added
S-waiting-on-review
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
This comment has been minimized.
This comment has been minimized.
scottmcm
force-pushed
the
inst-simplify-repeat-one
branch
from
b1a6483 to
699703e
Compare
oli-obk
approved these changes
Jan 10, 2025
oli-obk
requested changes
Jan 10, 2025
| // CHECK-LABEL: fn remove_generic_array | ||
| // CHECK: debug a => const ZeroSized: [T; 0]; | ||
| // CHECK-NOT: = []; | ||
| let a = [x; 0]; |
There was a problem hiding this comment.
Also add a test where the zero comes from a constant not a literal
| // CHECK: _0 = [move {{_[0-9]+}}]; | ||
| // CHECK-NOT: [move {{_[0-9]+}}; 1] | ||
|
|
||
| [x; 1] |
There was a problem hiding this comment.
Also test getting the 1 from a constant, not a literal. I think the normalization for that has already happened, but we've had some issues with that recently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created because when I was writing this case in GVN
https://github.com/rust-lang/rust/pull/133324/files#diff-292b215fdc6b59e3f3c4173c2270b14591c5673832fbfb05cd69a05c2ef0c30eR977-R979
I happened to notice that it worked for
[x]but not for[x; 1], so figured it would be good to simplify thatRepeatto the simplerAggregate.