CI: Remove libgcc.a linker workaround from repackaged NDK
#201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
rm-libgcc-workaround
branch
from
cb90899 to
231f206
Compare
[Rust 1.68 is now targeting NDK r25] instead of r17 and no longer tries to forcibly link against `libgcc.a`, which was removed since NDK r23 in favour of [only needing to link against `libunwind`]. Since this Rust release is over 1.5 years old, assume everyone is using at least 1.68 and drop the workaround from our repackaged NDK release. [Rust 1.68 is now targeting NDK r25]: https://blog.rust-lang.org/2023/03/09/Rust-1.68.0.html#other-changes [only needing to link against `libunwind`]: https://blog.rust-lang.org/2023/01/09/android-ndk-update-r25.html
MarijnS95
force-pushed
the
rm-libgcc-workaround
branch
from
231f206 to
8a5d92e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust 1.68 is now targeting NDK r25 instead of r17 and no longer tries to forcibly link against
libgcc.a, which was removed since NDK r23 in favour of only needing to link againstlibunwind. Since this Rust release is over 1.5 years old, assume everyone is using at least 1.68 and drop the workaround from our repackaged NDK release.