Fixed crash in EglGetProcAddress
on Win32-x86 platform
#1688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.md
if knowledge of this change could be valuable to usersSummary
Change the calling convention of the
EglGetProcAddress
declaration toextern "system"
to automatically use the correct calling convention for the platform.Details
The
EglGetProcAddress
function uses thestdcall
calling convention on theWin32-x86
platform, but it was previously declared asextern "C"
in the code.On the
Win32-x86
platform,extern "C"
functions use thecdecl
calling convention by default.This mismatch in calling conventions caused a crash.
By changing the declaration to
extern "system"
, the correct calling convention for the platform will be used automatically, preventing the crash.Testing
Win32-x86
platform.