Remove final constructor for Type

See doctrine#6704

src/Types/Exception/TypeArgumentCountError.php

@@ -0,0 +1,19 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Doctrine\DBAL\Types\Exception;
+
+use ArgumentCountError;
+use Exception;
+
+use function sprintf;
+
+/** @psalm-immutable */
+final class TypeArgumentCountError extends Exception implements TypesException
+{
+    public static function new(string $name, ArgumentCountError $previous): self
+    {
+        return new self(sprintf('Type "%s" cannot be registered through Type::addType because it requires arguments. Use Type::getTypeRegistry()->register instead.', $name), previous: $previous);
+    }
+}

src/Types/Type.php

@@ -4,9 +4,11 @@
 
 namespace Doctrine\DBAL\Types;
 
+use ArgumentCountError;
 use Doctrine\DBAL\Exception;
 use Doctrine\DBAL\ParameterType;
 use Doctrine\DBAL\Platforms\AbstractPlatform;
+use Doctrine\DBAL\Types\Exception\TypeArgumentCountError;
 
 use function array_map;
 
@@ -51,11 +53,6 @@ abstract class Type
 
     private static ?TypeRegistry $typeRegistry = null;
 
-    /** @internal Do not instantiate directly - use {@see Type::addType()} method instead. */
-    final public function __construct()
-    {
-    }
-
     /**
      * Converts a value from its PHP representation to its database representation
      * of this type.
@@ -144,7 +141,11 @@ public static function lookupName(self $type): string
      */
     public static function addType(string $name, string $className): void
     {
-        self::getTypeRegistry()->register($name, new $className());
+       try {
+           self::getTypeRegistry()->register($name, new $className());
+       } catch (ArgumentCountError $e) {
+           throw TypeArgumentCountError::new($name, $e);
+       }
     }
 
     /**

tests/Types/TypeTest.php

@@ -4,6 +4,8 @@
 
 namespace Doctrine\DBAL\Tests\Types;
 
+use Doctrine\DBAL\Tests\Functional\Schema\Types\MoneyType;
+use Doctrine\DBAL\Types\Exception\TypeArgumentCountError;
 use Doctrine\DBAL\Types\Type;
 use Doctrine\DBAL\Types\Types;
 use PHPUnit\Framework\Attributes\DataProvider;
@@ -39,4 +41,12 @@ public static function defaultTypesProvider(): iterable
             yield [$constantValue];
         }
     }
+
+    public function testAddTypeWhenTypeRequiresArguments(): void
+    {
+        self::expectException(TypeArgumentCountError::class);
+        self::expectExceptionMessage('Type "some_type" cannot be registered through Type::addType because it requires arguments. Use Type::getTypeRegistry()->register instead.');
+
+        Type::addType('some_type',  TypeWithConstructor::class);
+    }
 }

tests/Types/TypeWithConstructor.php

@@ -0,0 +1,20 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Doctrine\DBAL\Tests\Types;
+
+use Doctrine\DBAL\Platforms\AbstractPlatform;
+use Doctrine\DBAL\Types\Type;
+
+class TypeWithConstructor extends Type
+{
+    public function __construct(bool $requirement)
+    {
+    }
+
+    public function getSQLDeclaration(array $column, AbstractPlatform $platform) : string
+    {
+        return '';
+    }
+}