Skip to content

Commit

Permalink
Added requirements-grid to about page to demo the element
Browse files Browse the repository at this point in the history
  • Loading branch information
hexTileX committed Jan 18, 2020
1 parent 3c5b500 commit cf9e316
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
1 change: 1 addition & 0 deletions bower.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"time-elements": "^0.6.0",
"openidconnect-signin": "rwth-acis/openidconnect-signin#update-signin",
"activity-tracker": "rwth-acis/activity-tracker#~1.2.0",
"requirements-grid": "rwth-acis/requirements-grid#~1.5.1",
"paper-dialog-behavior": "PolymerElements/paper-dialog-behavior#^1.2.2",
"emoji-selector": "https://github.com/notwaldorf/emoji-selector.git#^1.1.1",
"iron-flex-layout": "PolymerElements/iron-flex-layout#^1.3.1",
Expand Down
12 changes: 8 additions & 4 deletions src/view-about.html
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<link rel="import" href="../bower_components/polymer/polymer.html">
<link rel="import" href="../bower_components/paper-material/paper-material.html">
<link rel="import" href="../bower_components/requirements-grid/requirements-grid.html">
<link rel="import" href="config-behavior.html">
<link rel="import" href="shared-styles.html">

Expand Down Expand Up @@ -75,9 +76,7 @@ <h2>Technical Background</h2>
Tracker Web component that asks the service above to fill its content.</li>
<li><a href="https://github.com/rwth-acis/requirements-grid" target="_blank">
https://github.com/rwth-acis/requirements-grid</a>: Yet another Web component. This one can be embedded on
3rd-party websites to display a grid of requirements in a specific project and category. You can see an
example on the <a href="https://wekit-community.org/ideas/" target="_blank">WEKIT Community website</a> where
new ideas for Augmented Reality tools are collected.</li>
3rd-party websites to display a grid of requirements in a specific project. You can see at the bottom of this page.</li>

This comment has been minimized.

Copy link
@istvank

istvank Jan 18, 2020

Member

Hi, the link to the WEKIT community page was there for a purpose; to show an active, real-world installation. Also, should be "You can see an example at the bottom of this page.", but it's somehow odd to only feature the requirements-grid on this page (out of context at the bottom of this page), because there would be many more interesting components. At least we should add a title, otherwise it appears below "How to contribute" which is confusing.

</ul>

<h2>How to Contribute</h2>
Expand All @@ -88,9 +87,14 @@ <h2>How to Contribute</h2>
our open source repositories, by sending us design proposals, or by volunteering to translate the page to one of
your native languages. Simply drop us an email at [email protected] and tell us about your idea.</p>


</paper-material>

<requirements-grid base-url="https://requirements-bazaar.org/beta/bazaar/"
project-id="1"
page="0"
per-page="4">
</requirements-grid>

</template>

<script>
Expand Down

0 comments on commit cf9e316

Please sign in to comment.