Hide RHN,yum in main output when Ubuntu/Debian is detected #220
Conversation
|
Sorry for the delay. Yes this is a good direction. If you don't want to source [[ -r "$1/etc/os-release" ]] &&
if [[ egrep "ID=\"?(rhel|fedora|centos)" ]]; then
packaging=rpm
elif [[ egrep "ID=\"?(ubuntu|debian)" ]]; then
packaging=deb
fiI'd worry more about variables colliding than |
|
Oh, "# I don't like blindly sourcing a file -- that provides a vector to screw with this script..." was already present. I don't mind it, nor do I think it's super likely to mess things up. We've been using my branch internally at Canonical for Ubuntu as part of ScoutPlane tool for months so the basics still work great. My biggest worry is that I could have broken some RH/N specific bits that I can't test. |
| if source "$1/etc/os-release" 2>/dev/null; then | ||
| distro_release="${c[Imp]}[ID]${c[0]} $ID" | ||
| if [[ "$ID" == "rhel" || "$ID" == "fedora" || "$ID" == "centos" ]]; then | ||
| packaging=rpm |
There was a problem hiding this comment.
Add packaging to the local vars of OSINFO()?
| echo -e " ${c[H2]}RHN:${c[0]} $rhn_serverURL$rhnProxyStuff" | ||
| echo -e " ${c[H2]}RHSM:${c[0]} $rhsm_hostname$rhsmProxyStuff" | ||
| fi | ||
| if [ $packaging = yum ]; then |
|
Looking at this again, I think the order which xsos determines and displays OS release is wrong now. It was originally written a long time ago to think of RHEL first, but these days Ubuntu should also be a first-class citizen. We could handle other distros which carry recent sosreport packages like AlmaLinux, Debian, Fedora, Mageia. I'm inclined to close this PR and re-order/rewrite |
I tried to code this so I don't think it will break when used for RHEL, but it seems like there a lot of corner cases.
Figured getting an ack that this is a good direction before doing extensive testing. Thanks!