Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] move pivotal tracker edit from engagement to app #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+27 −4
Open

[fix] move pivotal tracker edit from engagement to app #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/views/apps/_form.html.haml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
= f.url_field :deployment_url, label: 'Deployment Url'
= f.url_field :repository_url, label: 'Repository Url'
= f.url_field :code_climate_url, label: 'Code Climate Url'
= f.url_field :pivotal_tracker_url, label: 'Pivotal Tracker Url'
= f.text_area :features, rows: '5', label: 'App Initial Features'
= f.collection_select :org_id, Org.all, :id, :name, {label: 'Organization'}, {class: 'select2'}
= f.collection_select :status, App.statuses, :first, ->(x) { x.first.humanize}, {label: 'Status'}, {class: 'select2'}
Expand Down
3 changes: 2 additions & 1 deletion app/views/apps/show.html.haml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
.page-header
%h1
= link_to_unless @app.deployment_url.blank?, @app.name, @app.deployment_url, :target => '_blank'
= link_to_unless @app.repository_url.blank?, image_tag('octocat.png'), @app.repository_url, :target => '_blank'
= link_to_unless @app.repository_url.blank?, image_tag('octocat.png', title: 'GitHub Repository'), @app.repository_url, :target => '_blank'
= link_to_unless @app.pivotal_tracker_url.blank?, image_tag('tracker.png', size: '45x45', title: 'Pivotal Tracker'), @app.pivotal_tracker_url, :target => '_blank'
- unless (url = @app.code_climate_url).blank?
= link_to image_tag(url + '/badges/gpa.svg'), url, :target => '_blank'
= link_to image_tag(url + '/badges/coverage.svg'), url, :target => '_blank'
Expand Down
27 changes: 24 additions & 3 deletions features/app_features.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ Scenario: A user can add initial features while creating apps
When I fill in "App Description" with "Fake app description"
When I fill in "App Initial Features" with "Fake app features"
And I press "Create App"
And I follow "Fake app"
And I follow "Fake app"
Then I should see "App Initial Features"
And I should see "Fake app features"

Expand All @@ -60,6 +60,27 @@ Scenario: A user can add initial features while editing apps
And I follow "Edit App"
When I fill in "App Initial Features" with "app1 features"
And I press "Update App"
And I follow "app1"
And I follow "app1"
Then I should see "App Initial Features"
And I should see "app1 features"
And I should see "app1 features"

# Testing pivotal tracker url in app create
Scenario: A user can add pivotal tracker url while creating apps
Given I follow "New App"
When I fill in "App Name" with "Pivotal tracker app"
And I fill in "App Description" with "App with pivotal tracker url"
And I fill in "Pivotal Tracker Url" with "https://www.pivotaltracker.com/12345"
And I press "Create App"
And I follow "Pivotal tracker app"
Then I should see "Pivotal Tracker"
And I should see "https://www.pivotaltracker.com/12345"

# Testing pivotal tracker url in app edit
Scenario: A user can add pivotal tracker url while editing apps
Given I follow "app1"
And I follow "Edit App"
When I fill in "Pivotal Tracker Url" with "https://www.pivotaltracker.com/12345"
And I press "Update App"
And I follow "app1"
Then I should see "Pivotal Tracker"
And I should see "https://www.pivotaltracker.com/12345"