Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reordered express middleware to resolve server side render issue when… #188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

choch-o
Copy link

@choch-o choch-o commented Nov 18, 2016

… using webpack + react + express

Original version had an issue with the following steps:

  1. Run npm start at least once.
  2. Make some changes in any React component files.
  3. Run npm start again.
  4. Open it in browser.
  5. You'll see it loads changed code initially but refreshes back to code generated in Step 1

This issue was resolved by reordering express middleware so that static middleware is located below Webpack middlewares.

@choch-o
Copy link
Author

choch-o commented Nov 18, 2016

The issue is also addressed in Issue #160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant