Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add enospc tests #129

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: add enospc tests #129

wants to merge 4 commits into from

Conversation

saidsay-so
Copy link
Owner

@saidsay-so saidsay-so commented Nov 19, 2022

Also adds as_unprivileged_user! macro (which will allow what's described in #87).

The tests are buggy though, and I'm not sure on how to setup the CI to support those.

Waiting for removal of mutable requirement for context struct
Copy link
Collaborator

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the CI problem is that you don't know how to create a suitably small file system to run the test on? I can help with that. But if the file system is suitably small, will there be any other tests that fail?

rust/src/tests/errors/enospc.rs Outdated Show resolved Hide resolved
rust/src/utils.rs Show resolved Hide resolved
rust/src/tests/errors/enospc.rs Show resolved Hide resolved
@saidsay-so
Copy link
Owner Author

So the CI problem is that you don't know how to create a suitably small file system to run the test on? I can help with that. But if the file system is suitably small, will there be any other tests that fail?

No, I tested and there shouldn't be tests failing because of the file system size, the files are automatically deleted after and the limit is way above what's required to run the tests. However, as I said, I'm not sure on how to create a small file system for the CI to run in.

@saidsay-so saidsay-so marked this pull request as ready for review January 6, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants