Fix various ways of album cover download #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Olf0
reviewed
Dec 7, 2023
|
Wow, thank you very much, you are quick! This is looking very good. |
Olf0
changed the title
Olf0
reviewed
Dec 7, 2023
Olf0
changed the title
When listing albums, it's always for one unique artist, so artistcount is always 1 in this context.
Ensure that the cache directory for covers exists. Also, properly reload the artist image in artist list when a cover is associated to an artist. Rewrite the text position on cover with a direct calculation of the Y position, the anchors solution with alternating undefined values seems not to work properly, when a cover is associated to an artist for instance.
katastrofos.net is now using secure HTTP, replying with a 301 moved permanently when polled on HTTP only. Avoid HTML parsing on the result by using the query.php method instead of the HTML frontend provided by index.php.
|
Rebased on latest devel branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #30
katastrofos.net is now using secure HTTP, replying with a 301 moved permanently when polled on HTTP only. This issue was making the album cover download not working.
Ensure that the cache directory for covers exists. This issue, introduced by #21, was making impossible to see downloaded covers and choose one, for an artist for instance.