Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AboutPage.qml] Adopt changes from FileCase's AboutPage.qml #37

Merged
merged 5 commits into from
Feb 5, 2024

Conversation

Olf0
Copy link
Contributor

@Olf0 Olf0 commented Feb 4, 2024

[Add Damien and me as contributors]
ToDo: Add two translatable strings and move other string references for AboutPage.qml in translations/flowplayer.ts

ToDo: Add two translatable strings and move other string references for `AboutPage.qml` in `translations/flowplayer.ts`
@Olf0 Olf0 added the documentation Improvements or additions to documentation label Feb 4, 2024
@Olf0 Olf0 self-assigned this Feb 4, 2024
Also mind to update translatable strings in `translations/flowplayer.ts`
@Olf0 Olf0 changed the title [AboutPage.qml] Add Damien and me as conributors [AboutPage.qml] Adopt changes from FileCase's AboutPage.qml Feb 4, 2024
Copy link
Contributor Author

@Olf0 Olf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Olf0 Olf0 merged commit 6a8e681 into devel Feb 5, 2024
1 check passed
@Olf0 Olf0 deleted the add-contributors branch February 5, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant