Add a debug flag that enables wire logging for git http requests #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjneasbi
requested review from
afalko,
avimanyum and
jeetchoudhary
as code owners
cjneasbi
commented
Sep 27, 2023
Comment on lines
+147
to
+156
| <dependency> | ||
| <groupId>com.squareup.okhttp3</groupId> | ||
| <artifactId>okhttp</artifactId> | ||
| <version>4.9.1</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.squareup.okhttp3</groupId> | ||
| <artifactId>logging-interceptor</artifactId> | ||
| <version>4.9.1</version> | ||
| </dependency> |
There was a problem hiding this comment.
For instrumenting the client with logging functionality.
cjneasbi
commented
Sep 27, 2023
Comment on lines
+201
to
+208
| public static String gitApiToken(final Function<String, String> envFunc, final Consumer<Integer> exitFunc) { | ||
| final String token = envFunc.apply("git_api_token"); | ||
| if (Objects.isNull(token)) { | ||
| log.error("Please provide GitHub token in environment variables."); | ||
| exitFunc.accept(3); | ||
| } | ||
| return token; | ||
| } |
There was a problem hiding this comment.
Moved from within initializeDockerfileGithubUtil
cjneasbi
commented
Sep 27, 2023
Comment on lines
+214
to
+220
| public static String gitApiUrl(final Namespace ns, final Function<String, String> envFunc) throws IOException { | ||
| return Optional.ofNullable( | ||
| Optional.ofNullable(ns.getString(GIT_API)) | ||
| .orElse(envFunc.apply("git_api_url")) | ||
| ) | ||
| .orElseThrow(() -> new IOException("No Git API URL in environment variables nor on the commmand line.")); | ||
| } |
There was a problem hiding this comment.
Moved from within initializeDockerfileGithubUtil
cjneasbi
commented
Sep 27, 2023
| @@ -54,7 +54,7 @@ public void execute(final Namespace ns, DockerfileGitHubUtil dockerfileGitHubUti | |||
| log.error("Could not initialize the Image tage store. Exception: ", e); | |||
| } | |||
|
|
|||
| if (ns.get(Constants.SKIP_PR_CREATION)) { | |||
| if (ns.getBoolean(Constants.SKIP_PR_CREATION)) { | |||
There was a problem hiding this comment.
Fixes error of trying to cast Object to boolean
cjneasbi
commented
Sep 27, 2023
| @@ -39,7 +39,7 @@ public DockerfileGitHubUtil(GitHubUtil gitHubUtil) { | |||
| this.gitHubUtil = gitHubUtil; | |||
| } | |||
|
|
|||
| protected GitHubUtil getGitHubUtil() { return gitHubUtil; } | |||
| public GitHubUtil getGitHubUtil() { return gitHubUtil; } | |||
There was a problem hiding this comment.
Visible for testing
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1125 +/- ##
============================================
+ Coverage 84.62% 85.69% +1.07%
- Complexity 378 385 +7
============================================
Files 27 27
Lines 1255 1272 +17
Branches 166 165 -1
============================================
+ Hits 1062 1090 +28
+ Misses 157 146 -11
Partials 36 36
|
afalko
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.