@W-17066806 add guard to CHR function #151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,7 +34,7 @@ public FormulaCommand getCommand(FormulaAST node, FormulaContext context) { | |||
|
|
|||
| @Override | |||
| public SQLPair getSQL(FormulaAST node, FormulaContext context, String[] args, String[] guards, TableAliasRegistry registry) { | |||
| String guard = SQLPair.generateGuard(guards, args[0] + "<1"); | |||
| String guard = SQLPair.generateGuard(guards, args[0] + "<1 OR " + args[0] + ">1114111"); | |||
There was a problem hiding this comment.
you can make it safer.
"(" + args[0] + "<1 OR " + args[0] + ">1114111)"
|
@dougdew64 Your commit is not signed!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added guard for CHR function so that inputs larger than 1114111 cause error.
Also, commented out some oracle tests, per our goal of focusing this repo on postgres.