Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, fix minor issues #348

Merged
merged 6 commits into from
Jan 14, 2025
Merged

Update dependencies, fix minor issues #348

merged 6 commits into from
Jan 14, 2025

Conversation

lkrms
Copy link
Collaborator

@lkrms lkrms commented Jan 14, 2025

No description provided.

lkrms added 6 commits January 14, 2025 10:25
- Added in error when updating generated provider interfaces
- In `SyncEntityProvider`, resolve custom subclasses to base entities
  serviced by the provider if necessary
- Add `SyncUtil::getServicedEntityType()`

This change means sync operations performed on a `$provider` via
`$provider->with(<entity>::class)` are resolved against a parent of
`<entity>` if (a) `$provider` doesn't service `<entity>` but does
service one of its non-abstract parents, and (b) the service container
resolves that parent to `<entity>`.
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 56.25000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 71.29%. Comparing base (0fdf4e7) to head (c43e2c3).
Report is 10 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...e/Rules/HasMutatorReadWritePropertiesExtension.php 0.00% 12 Missing ⚠️
src/Toolkit/Sync/SyncUtil.php 88.88% 2 Missing ⚠️
Additional details and impacted files
Components Coverage Δ
Cache 100.00% <ø> (ø)
Cli 77.63% <ø> (ø)
Collections 86.19% <ø> (ø)
Console 65.63% <ø> (ø)
Container 64.64% <ø> (-0.50%) ⬇️
Contracts ∅ <ø> (∅)
Core 78.66% <ø> (ø)
Curler 64.37% <ø> (ø)
Db 0.00% <ø> (ø)
Http 79.20% <ø> (ø)
Iterators 83.12% <ø> (ø)
PHPDoc 91.54% <ø> (ø)
PHPStan 96.85% <0.00%> (-3.15%) ⬇️
Polyfills 100.00% <ø> (ø)
Sli 39.48% <ø> (ø)
Sync 66.59% <90.00%> (+0.06%) ⬆️
Testing 77.16% <ø> (ø)
Utils 93.26% <ø> (-0.04%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkrms lkrms merged commit 276c26d into main Jan 14, 2025
13 of 15 checks passed
@lkrms lkrms deleted the cleanup branch January 14, 2025 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant