Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue Utility class review #357

Merged
merged 5 commits into from
Jan 28, 2025
Merged

Continue Utility class review #357

merged 5 commits into from
Jan 28, 2025

Conversation

lkrms
Copy link
Collaborator

@lkrms lkrms commented Jan 28, 2025

No description provided.

lkrms added 2 commits January 28, 2025 16:44
- In `Str::expandTabs()` and `expandLeadingTabs()`, add support for
  strings with two or more different end-of-line sequences
- In `Str::expandLeadingTabs()`, add support for an arbitrary
  combination of tabs and spaces at the start of each line
- Fix upstream return type issue in `Regex::replace()`
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.42%. Comparing base (6ec6bc9) to head (d60fdcf).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
Components Coverage Δ
Cache 100.00% <ø> (ø)
Cli 77.66% <ø> (ø)
Collections 86.19% <ø> (ø)
Console 65.63% <ø> (ø)
Container 65.13% <ø> (ø)
Contracts ∅ <ø> (∅)
Core 78.66% <ø> (ø)
Curler 64.37% <ø> (ø)
Db 0.00% <ø> (ø)
Http 79.20% <100.00%> (ø)
Iterators 83.12% <ø> (ø)
PHPDoc 91.54% <ø> (ø)
PHPStan 100.00% <ø> (ø)
Polyfills 100.00% <ø> (ø)
Sli 39.53% <ø> (ø)
Sync 66.59% <100.00%> (ø)
Testing 77.16% <ø> (ø)
Utils 93.61% <100.00%> (+0.07%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lkrms added 3 commits January 28, 2025 17:22
- Rename `Arr::isIndexed()` to `hasNumericKeys()`
- Make `Date::immutable()` argument optional
@lkrms lkrms merged commit aad4bae into main Jan 28, 2025
15 checks passed
@lkrms lkrms deleted the review branch January 28, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant