Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repositories): fix clean parameter #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robinelfrink
Copy link

@robinelfrink robinelfrink commented Dec 17, 2022

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

#66
saltstack/salt#26605

Describe the changes you're proposing

Before:

----------
          ID: /etc/apt/sources.list.d
    Function: file.directory
      Result: None
     Comment: The following files will be changed:
              /etc/apt/sources.list.d/saltstack-binary.list: removed - Removed due to clean
              /etc/apt/sources.list.d/debian_security-binary.list: removed - Removed due to clean
              /etc/apt/sources.list.d/debian-binary.list: removed - Removed due to clean
              /etc/apt/sources.list.d/debian_backports-binary.list: removed - Removed due to clean
              /etc/apt/sources.list.d/debian_updates-binary.list: removed - Removed due to clean
     Started: 15:02:30.661539
    Duration: 2.281 ms
     Changes:   
              ----------
              /etc/apt/sources.list.d/debian-binary.list:
                  ----------
                  removed:
                      Removed due to clean
              /etc/apt/sources.list.d/debian_backports-binary.list:
                  ----------
                  removed:
                      Removed due to clean
              /etc/apt/sources.list.d/debian_security-binary.list:
                  ----------
                  removed:
                      Removed due to clean
              /etc/apt/sources.list.d/debian_updates-binary.list:
                  ----------
                  removed:
                      Removed due to clean
              /etc/apt/sources.list.d/saltstack-binary.list:
                  ----------
                  removed:
                      Removed due to clean

Summary for local
------------
Succeeded: 9 (unchanged=1, changed=1)
Failed:    0
------------
Total states run:     9
Total run time: 583.226 ms

After:

local:

Summary for local
-------------
Succeeded: 14
Failed:     0
-------------
Total states run:     14
Total run time:  590.548 ms

In #66 fixes were made to prevent files from being removed and then added again. However it seems that the intended change was forgotten in apt/repositories.sls. This PR fixes the fix.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@robinelfrink robinelfrink marked this pull request as draft September 11, 2024 12:03
@robinelfrink robinelfrink marked this pull request as ready for review September 11, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant