cloudplow: simplify filtering tasks

moved path check into config generation block so we skip it otherwise

roles/cloudplow/tasks/main.yml

@@ -21,15 +21,7 @@
 
 - name: Filter Rclone remotes
   ansible.builtin.set_fact:
-    cloudplow_remotes: "{{ cloudplow_remotes + [item] }}"
-  loop: "{{ rclone.remotes }}"
-  when: item.settings.upload
-
-- name: Filter Rclone upload_from on remotes
-  ansible.builtin.set_fact:
-    cloudplow_upload_paths_unique: "{{ cloudplow_upload_paths_unique + [item.settings.upload_from] }}"
-  loop: "{{ rclone.remotes }}"
-  when: item.settings.upload and (item.settings.upload_from not in cloudplow_upload_paths_unique)
+    cloudplow_remotes: "{{ rclone.remotes | selectattr('settings.upload', 'equalto', True) | list }}"
 
 - name: Cloudplow tasks
   when: (cloudplow_remotes | length > 0)

roles/cloudplow/tasks/subtasks/settings.yml

@@ -34,6 +34,14 @@
 - name: Settings | New 'config.json' tasks
   when: (not cloudplow_config.stat.exists)
   block:
+    - name: Filter Rclone upload_from on remotes
+      ansible.builtin.set_fact:
+        cloudplow_upload_paths_unique: "{{ rclone.remotes
+                                           | selectattr('settings.upload', 'defined')
+                                           | selectattr('settings.upload', 'equalto', true)
+                                           | map(attribute='settings.upload_from')
+                                           | unique }}"
+
     - name: Settings | Fail if duplicate folders where found.
       ansible.builtin.fail:
         msg: