Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firefox): make the wait task less disruptive #337

Closed
wants to merge 1 commit into from

Conversation

keldian
Copy link
Contributor

@keldian keldian commented Feb 25, 2024

No description provided.

@saltydk
Copy link
Member

saltydk commented Feb 25, 2024

Less disruptive by making it pointless or?

@keldian
Copy link
Contributor Author

keldian commented Feb 25, 2024

Well the idea of that task was never to stop the execution of the role, it's just to allow enough time for directories to populate, so that the next task doesn't delete the wrong ones. I don't view it as pointless as 30s should be enough time for that to happen anyway. *shrug*

@saltydk
Copy link
Member

saltydk commented Feb 25, 2024

Then change the task to look for the files instead of make it silently fail if there is something wrong with the deployment

@saltydk
Copy link
Member

saltydk commented Feb 25, 2024

You can shrug all you want, it doesn't change how it looks.

@saltydk
Copy link
Member

saltydk commented Feb 25, 2024

This just seems to be in response to what sevos wrote on the discord and I'm betting he just deployed ufw and broke it himself.

@keldian
Copy link
Contributor Author

keldian commented Feb 25, 2024

I know. :p Just shrugging because I don't mind canceling this, especially if you figure it was fine as it was.

Then change the task to look for the files instead of make it silently fail if there is something wrong with the deployment

I'll look into that at some point.

@keldian keldian closed this Feb 25, 2024
@keldian keldian deleted the fxfix branch February 25, 2024 00:59
@saltydk
Copy link
Member

saltydk commented Feb 25, 2024

Deluge role has an example from what I remember.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants