Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Wrapperr docker volume #409

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

Kevin2kkelly
Copy link
Contributor

Description

It looks like at some point there was an upstream change to the Wrapperr volume mapping with regards to the internal container path. A new install of the app would lose any configuration changes if the tag was run again.

The Wrapperr docker compose example from their GitHub has the volume mapping as './my-folder:/app/config', but the Sandbox role uses "{{ wrapperr_paths_location }}:/var/www/html/config". This PR updates the mapping to what is currently expected by Wrapperr.

How Has This Been Tested?

  • I added the following entry to my inventory and ran the wrapperr tag. I then configured the app and ran the wrapperr tag again. After running the tag a second time the configuration changes persist.
wrapperr_docker_volumes_default:
  - "{{ wrapperr_paths_location }}:/app/config"

I'd appreciate it if a reviewer did a sanity check and considered if this would break any other users existing Wrapper setups, I think that's a little over my head. Thanks!

@owine owine merged commit bace424 into saltyorg:master Jan 8, 2025
183 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants