bump delta kernel

samansmink · Jun 10, 2024 · ab61885 · ab61885
1 parent a2d6601
commit ab61885
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 10 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -60,7 +60,7 @@ endif()
 ExternalProject_Add(
         ${KERNEL_NAME}
         GIT_REPOSITORY "https://github.com/delta-incubator/delta-kernel-rs"
-        GIT_TAG 08f0764a00e89f42136fd478823d28278adc7ee8
+        GIT_TAG 823367e4dc13b627914412ee2ca7933a1c7b822a
         CONFIGURE_COMMAND ""
         UPDATE_COMMAND ""
         BUILD_IN_SOURCE 1

diff --git a/src/delta_utils.cpp b/src/delta_utils.cpp
@@ -226,7 +226,7 @@ static unordered_map<string, TableFilter*> PrunePredicates(unordered_map<string,
 }
 
 uintptr_t PredicateVisitor::VisitPredicate(PredicateVisitor* predicate, ffi::KernelExpressionVisitorState* state) {
-    auto filters = PrunePredicates(predicate->column_filters);
+    auto filters = predicate->column_filters;
 
     auto it = filters.begin();
     auto end = filters.end();
@@ -312,7 +312,7 @@ uintptr_t PredicateVisitor::VisitFilter(const string &col_name, const TableFilte
         case TableFilterType::CONJUNCTION_AND:
             return VisitAndFilter(col_name, static_cast<const ConjunctionAndFilter&>(filter), state);
         default:
-            throw NotImplementedException("Attempted to push down unimplemented filter type: '%s'", EnumUtil::ToString(filter.filter_type));
+            return ~0;
     }
 }
 

diff --git a/test/sql/dat/basic_append.test b/test/sql/dat/basic_append.test
@@ -56,9 +56,6 @@ FROM delta_scan('${DAT_PATH}/out/reader_tests/generated/basic_append/delta')
 2
 3
 
-# TODO: Figure out what's wrong here
-mode skip
-
 # Now we add a filter that filters out one of the files
 query II
 SELECT letter, number
@@ -67,8 +64,6 @@ WHERE number < 2
 ----
 a	1
 
-mode unskip
-
 # Now we add a filter that filters out the other file
 query III
 SELECT a_float, letter, number, 
@@ -77,8 +72,6 @@ WHERE number > 4
 ----
 5.5	e	5
 
-mode skip
-
 # Now we add a filter that filters out all columns
 query III
 SELECT a_float, number, letter