add-debug-tests

samansmink · May 27, 2024 · cfeb742 · cfeb742
1 parent dc00b19
commit cfeb742
Show file tree

Hide file tree

Showing 4 changed files with 46 additions and 13 deletions.
diff --git a/.github/workflows/GeneratedTests.yml b/.github/workflows/GeneratedTests.yml
@@ -50,4 +50,44 @@ jobs:
       - name: Test
         shell: bash
         run: |
-          GENERATED_DATA_AVAILABLE=1 make test
+          GENERATED_DATA_AVAILABLE=1 make test
+
+  debug-tests-linux:
+    name: Generated Tests (Linux)
+    runs-on: ubuntu-latest
+    env:
+      GEN: ninja
+      VCPKG_TOOLCHAIN_PATH: ${{ github.workspace }}/vcpkg/scripts/buildsystems/vcpkg.cmake
+
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          fetch-depth: 0
+          submodules: 'true'
+
+      - name: Install
+        shell: bash
+        run: sudo apt-get update -y -qq && sudo apt-get install -y -qq ninja-build
+
+      - name: Setup Ccache
+        uses: hendrikmuhs/ccache-action@main
+        with:
+          key: ${{ github.job }}
+
+      - uses: actions/setup-python@v5
+        with:
+          python-version: '3.11'
+
+      - name: Setup vcpkg
+        uses: lukka/[email protected]
+        with:
+          vcpkgGitCommitId: a1a1cbc975abf909a6c8985a6a2b8fe20bbd9bd6
+
+      - name: Build
+        shell: bash
+        run: make generate-data
+
+      - name: Test
+        shell: bash
+        run: |
+          make test_debug
diff --git a/duckdb b/duckdb
diff --git a/test/sql/dat/basic_append.test b/test/sql/dat/basic_append.test
@@ -9,10 +9,11 @@ require delta
 require-env DAT_PATH
 
 # Note: this table has 2 parquet files:
-# - part-00000-ef42f28f-e8e8-4d54-b51f-c3af96c72a44-c000.snappy.parquet
+# - <file a>.snappy.parquet
 #   - contains letters a,b,c
-# - part-00000-c156ac8b-f738-4479-803d-750072dd4c51-c000.snappy.parquet
+# - <file b>.snappy.parquet
 # 	- contains letters d,e
+mode skip
 
 query I
 SELECT count(*)
@@ -56,8 +57,7 @@ FROM delta_scan('${DAT_PATH}/out/reader_tests/generated/basic_append/delta')
 2
 3
 
-# TODO: Figure out what's wrong here
-mode skip
+# FIXME add tests to confirm this filters out the files!
 
 # Now we add a filter that filters out one of the files
 query II
@@ -67,8 +67,6 @@ WHERE number < 2
 ----
 a	1
 
-mode unskip
-
 # Now we add a filter that filters out the other file
 query III
 SELECT a_float, letter, number, 
@@ -77,8 +75,6 @@ WHERE number > 4
 ----
 5.5	e	5
 
-mode skip
-
 # Now we add a filter that filters out all columns
 query III
 SELECT a_float, number, letter

diff --git a/test/sql/generated/tpcds.test_slow b/test/sql/generated/tpcds.test_slow
@@ -25,9 +25,6 @@ create view ${table} as from ${table}_delta
 
 endloop
 
-# FIXME: for now this sporadically hits too many open files
-mode skip
-
 mode output_result
 
 loop i 1 9
+3 −0		src/common/multi_file_reader.cpp
+1 −0		src/include/duckdb/common/multi_file_reader.hpp