Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export profile metrics #16

Merged
merged 3 commits into from
Feb 2, 2025

Conversation

synarete
Copy link
Collaborator

Export profile stats as Prometheus metrics. Convert (a subset of) smbstatus --profile --json stats information into Prometheus metrics. Use operations-counter as metrics and additional information (in/out bytes, time, operation-name) as labels. Disabled by default, enabled when passing --profile command-line flag.

Convert (a subset of) 'smbstatus --profile --json' stats information
into Prometheus metrics. Use operations-counter as metrics and
additional information (in/out bytes, time, operation-name) as labels.
Disabled by default.

Signed-off-by: Shachar Sharon <[email protected]>
When '--profile' flag is passed to 'smbmetrics' collect and export also
SMB profile counters. Disabled by default.

Signed-off-by: Shachar Sharon <[email protected]>
Add doc and output sample of `smbmetrics --profile` mode.

Signed-off-by: Shachar Sharon <[email protected]>
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me.
I feel really rusty looking at this, but nothing jumps out at me as an issue.

Copy link

@avanthakkar avanthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@synarete synarete merged commit 8d4dce1 into samba-in-kubernetes:main Feb 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants