Add Testing Library setup and some boilerplate tests for current comp… #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrgriffiniii
approved these changes
Feb 19, 2020
| expect(getByTestId('expand-collapse-button')).toBeInTheDocument() | ||
| }) | ||
|
|
||
| // Not really sure yet how to test <StyledChildResourceTree /> and |
There was a problem hiding this comment.
👍 I can create an issue for this.
| ...render(<Provider store={store}>{ui}</Provider>), | ||
| // adding `store` to the returned utilities to allow us | ||
| // to reference it in our tests (just try to avoid using | ||
| // this to test implementation details). |
| </Select> | ||
| </FormControl> | ||
| ); | ||
| const useStyles = makeStyles({ |
There was a problem hiding this comment.
Thank you for adding this, I know that the usage of the Material UI should be adjusted, I can create an issue for this as well.
There was a problem hiding this comment.
Sounds good. We can only use the Material UI Hooks way of applying styles to functional components. So in the more involved, class components I left the current Material UI style.
If you wanted to create an issue for converting class components to Hooks, I'd be happy to help out with that if you want? And for that work, does a dev environment exist to run the front end working off the back-end to see it in action?
jrgriffiniii
approved these changes
Feb 19, 2020
This was referenced Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…onents
This more or less should wrap up the intent of #24 . The tests are stubbed out mainly verifying the presence of layout elements. Once I or anyone connects to a back end to see this running in action, it'll be easier to add more behavioral tests to each component.
Any questions on Testing Library, let me know. Everything should follow the packages doc's fairly closely.