-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Deprecate Hyrax's Noid functionality #1049
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave this PR open until we've had a chance to discuss the ramifications on the May 31st community tech call. Thanks!
I'm not sure how to get these tests to run. Travis says: "The repository at projecthydra-labs/hyrax was not found." |
@jcoyne have you tried pushing a change to the branch? |
48951ef
to
29fc158
Compare
Enable using ActiveFedora::Noid::Model if desired
@@ -500,29 +501,6 @@ def paranoid_edit_permissions | |||
end | |||
end | |||
|
|||
describe 'assign_id' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block tests the same stuff as the block starting at line 222
I see reasons to make using Fedora's UUIDs the default (faster, less error prone, etc.) — but I don't see any reason for deprecating NOIDs. I've heard tell of errors minting NOIDs at scale, but have never seen these personally. |
@escowles It does not deprecate the use of noids, It just deprecates the tight coupling between hyrax and AF-noid. You can still use AF noid by including |
Link to background discussion on this change? I would expect implications for the maintenance and stability of the NOID codebase over time. |
@HackMasterA I'm not sure I understand this statement:
The only way I can see decoupling components would affect maintenance is that people who are not using those components would not be involved in their maintenance. That seems fair, right? I'm not sure how stability would be affected in any way. |
@HackMasterA I don't think there has been any prior discussion. In hyku we had to stop using AF-noid because it was a bottleneck on large imports. |
Can you say more about what you observed with hyku? |
We'll be discussing on the Tech call momentarily, for folks who can dial in. |
We decided not to move forward with deprecating NOID usage in Hyrax given the community's desire to keep using NOIDs. |
@mjgiarlo so we close this? |
@atz please don't. The feedback from this meeting was that certain parts of the PR were acceptable, but outright deprecation was not. So I'd like to rework it when I come back to Hyrax at some point. |
Working on an approach to this in: Which will require: |
Where are things at with this? samvera/hydra-head#425 was merged, #2256 had been blocked by two pulls that have been merged. Looks like only samvera/active_fedora#1295 is left, where there's an open question but no opposition, it seems? |
NOID has been the favored ID generator since Sufia's early days. But there are some issues with NOID:
Deprecating NOID integration will enable us to address these issues.
NOTE If you were using noids, you must now explicitly turn them on:
config.enable_noids = true
. Previously this was the default.