Voting Pages UI #66
Voting Pages UI #66
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| import axios from "axios"; | ||
| import { VoteSelection } from "../util/Types"; | ||
|
|
||
| export const createVote = async ( |
There was a problem hiding this comment.
can we turn this into a react query hook instead?
|
|
||
| const createVoteMutation = useMutation({ | ||
| mutationFn: async (selectedVote: VoteSelection) => { | ||
| return createVote(question.uuid, member_id, selectedVote); |
There was a problem hiding this comment.
oh nvm, i see what's happening here. ignore above comment
| }, | ||
| onSuccess: () => { | ||
| setSubmitted(true); | ||
| // TODO: this success should update the voting history query however |
There was a problem hiding this comment.
what do you mean by this? could we just invalidate the voting history query?
There was a problem hiding this comment.
Whenever a vote is successfully created it should update the content on the vote record page ( your vote and submssion). The useMutation can force an endpoint to refresh using invalidate query, so I was trying get the endpoint that fetches the votingHistory to refresh, but adding that in was essentially skipping the confirmation message shown at the end of the vote, which isn't ideal.
| queryKey: ["voting", "history", id], | ||
| queryFn: async (): Promise<VoteHistory[]> => { | ||
| const response = await axios.get<VoteHistory[]>( | ||
| `/api/voting/getVotingRecord?id=${id}` |
There was a problem hiding this comment.
can we change this a bit to make the endpoint clearer, i.e. getVotingRecordByMemberId
| @@ -9,7 +9,7 @@ import reportWebVitals from "./reportWebVitals"; | |||
| import { Member } from "./util/Types"; | |||
|
|
|||
| // Create a client | |||
| const queryClient = new QueryClient(); | |||
| export const queryClient = new QueryClient(); | |||
There was a problem hiding this comment.
why does this need to be exported?
There was a problem hiding this comment.
Its needed for the (eventual?) invalidateQuery within the useMutation, i.e queryClient.invalidateQuery(queryKey)
Adds the Voting History Page and Vote Page following the figma styling
I'll post screenshots and what not in a bit