Sptensor compare #331
Merged
Sptensor compare #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adly than before.
* Locally verified 1.24, wouldn't be too hard to update to support older if desired
…ry around 0 to reduce arguments and potentially capture eq and neq
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve #287
I added tests that should cover the enumerated cases. I also cleaned up the inconsistency Jeremy found. Previously our eq/ne were inconsistent with lt,le,gt,ge where the first yielded boolean tensors and the later yielded float tensors with 1.0/0.0 for the boolean context. I think tensor and sptensor still are mismatched on this with tensor returning booleans. There is already a ticket for thinking about this.
I pulled the gt/lt/le/ge code into a common method but it's a little messier than it could be but I think incremental progress is beneficial.
I branched off of #330 since I had that locally. If that proves controversial I assume I can rebase to main without too much headache.
📚 Documentation preview 📚: https://pyttb--331.org.readthedocs.build/en/331/