Add support for École supérieure privée d'ingénierie et de technologie #423
Conversation
|
The build process has succeeded. |
|
i test it , the download process works fine |
blackboard_sync/universities.json
Outdated
| @@ -670,6 +670,16 @@ | |||
| }, | |||
| "api_url": "https://mstc.blackboard.com" | |||
| }, | |||
| { | |||
| "name": "École supérieure privée d'ingénierie et de technologie", | |||
There was a problem hiding this comment.
There is only a small problem: your app is not compatible with special French characters.
So, I suggest renaming it to: Ecole superieure privee d'ingenierie et de technologie
There was a problem hiding this comment.
What do you mean it is not compatible? Is there an error with the UI?
|
@TheLime1 Could you let me know the error you are seeing regarding the french characters? |
|
|
|
I think it's an encoding issue, but the download process works |
|
I think I can just rebase it, so no action needed on your part. |
sanjacob
force-pushed
the
uni-2594111049
branch
from
96dcfef to
16f6390
Compare
|
i was gonna test it right now hahah , thank you :) |
|
Fixed |
|
@TheLime1 Just one more thing before I merge this. All other universities have their name in Title Case, so it would be a good idea to follow this format. However, I'm not sure how this would look given that it's in French. From their website and social media it is similar to what you provided but some of them have "Technologies" in plural rather than singular. Moreover they have written "Ecole" without the accent (example). Just edit the university name to be in the correct format in Title Case and I'll merge it. |
|
i dont have direct editing rights here , so i made #428 |
|
You can edit the issue directly and the PR will also update. Furthermore, I'd rather have no abbreviations in the name. I don't need you to follow the name as it appears on their website. I just want you to provide a Title Case version of the one you had already given me, or the one you think most appropriate, but in Title Case. |
sanjacob
force-pushed
the
uni-2594111049
branch
from
16f6390 to
770c850
Compare
|
@sanjacob you can take a look |
|
@TheLime1 So is the accent on the first letter optional? Just curious |
|
In French, it's rare to use accents on uppercase letters, but both are correct |
sanjacob
force-pushed
the
uni-2594111049
branch
from
770c850 to
9266650
Compare
Created on behalf of @TheLime1
Closes #422