Fix project_id handling for RequestContext objects #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandzwerg
approved these changes
Nov 15, 2024
|
@joker-at-work Can I get a PR review here? |
|
@joker-at-work added your reasonable, and important feedback. Please let me know if this is reasonable for you now. |
|
Also @sandzwerg - if you can patch and deploy this so we can test, that would be great. I go on vacation until the end of the year on Wednesday, so there isn't a lot of time to sort through this. |
joker-at-work
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The audit middleware was assuming all contexts were dictionary-like objects,
causing AttributeError when handling Ironic requests where context is a
RequestContext object. This change adds proper type checking to safely handle
both dictionary and object-style contexts.
Error fixed:
AttributeError: 'RequestContext' object has no attribute 'get'