chore: bug fixes

sardinedev · Mar 10, 2024 · 28d07c4 · 28d07c4
1 parent 36b8f22
commit 28d07c4
Show file tree

Hide file tree

Showing 11 changed files with 93 additions and 34 deletions.
diff --git a/.nvmrc b/.nvmrc
@@ -0,0 +1 @@
+20.11.1
diff --git a/src/components/IssueGrid/IssueGrid.tsx b/src/components/IssueGrid/IssueGrid.tsx
@@ -34,10 +34,12 @@ function clampIssuesPerPage({
       (a, b) => parseInt(a.issue_number) - parseInt(b.issue_number)
     );
   }
-  return issueList.slice(
+  const trimmedList = issueList.slice(
     (currentPage - 1) * issuesPerPage,
     currentPage * issuesPerPage
   );
+
+  return trimmedList;
 }
 
 function Issue({ id, name, image, issue_number }: ShortIssue) {
@@ -51,9 +53,9 @@ function Issue({ id, name, image, issue_number }: ShortIssue) {
     }
     if (!image) {
       getIssue();
-      console.warn("Issue", id, "is missing an image");
     }
-  }, [image]);
+  }, []);
+
   return (
     <li>
       <a href={"/comic/" + id}>
@@ -80,7 +82,6 @@ export function IssueGrid({
   issuesPerPage = 50,
 }: Props) {
   const $sortDirection = useStore($sort);
-
   const [issues, setIssues] = useState<ShortIssue[] | undefined>(
     clampIssuesPerPage({
       issuesPerPage,
@@ -100,6 +101,7 @@ export function IssueGrid({
       })
     );
   }, [issueList, currentPage, issuesPerPage, $sortDirection]);
+
   return (
     <>
       <ul class="grid gap-4 grid-cols-2 sm:grid-cols-3 md:grid-cols-5 mt-8">

diff --git a/src/components/PageNavigator.tsx b/src/components/PageNavigator.tsx
@@ -1,10 +1,15 @@
+import { $sort } from "../stores/sort.store";
+
 type Props = {
+  /** The series ID is used to compose the URL on the link navigation */
   id: number | string;
   numberOfPages: number;
   currentPage: number;
 };
 export function PageNavigator({ id, numberOfPages, currentPage }: Props) {
+  const sort = $sort.get();
   let pagesArray: (string | number)[] = [];
+
   if (numberOfPages > 8) {
     if (currentPage < 5) {
       pagesArray = [1, 2, 3, 4, 5, "...", numberOfPages];
@@ -41,7 +46,7 @@ export function PageNavigator({ id, numberOfPages, currentPage }: Props) {
               <span>{page}</span>
             ) : (
               <a
-                href={`/series/${id}/${page}`}
+                href={`/series/${id}/${page}?sort=${sort}`}
                 class={page === currentPage ? "underline" : ""}
               >
                 {page}

diff --git a/src/layouts/Layout.astro b/src/layouts/Layout.astro
@@ -1,4 +1,5 @@
 ---
+import { ViewTransitions } from "astro:transitions";
 import Header from "../components/Header.astro";
 interface Props {
   title: string;
@@ -16,6 +17,7 @@ const { title } = Astro.props;
     <link rel="icon" type="image/svg+xml" href="/favicon.svg" />
     <meta name="generator" content={Astro.generator} />
     <title>{title}</title>
+    <ViewTransitions />
   </head>
   <body class="bg-slate-900 font-sans text-slate-50">
     <Header />
@@ -25,10 +27,10 @@ const { title } = Astro.props;
     <footer class="p-4 text-center text-xs">
       <p>&copy; 2024 Sardines Reading Comics</p>
     </footer>
+    <style is:global>
+      .hide-scrollbar {
+        scrollbar-width: none;
+      }
+    </style>
   </body>
-  <style is:global>
-    .hide-scrollbar {
-      scrollbar-width: none;
-    }
-  </style>
 </html>
diff --git a/src/pages/comic/[id]/index.astro b/src/pages/comic/[id]/index.astro
@@ -82,4 +82,3 @@ const title = data
     )
   }
 </Layout>
-../../../util/comicvine.types
diff --git a/src/pages/index.astro b/src/pages/index.astro
@@ -68,6 +68,3 @@ try {
     )
   }
 </Layout>
-
-<style></style>
-../util/kv
diff --git a/src/pages/series/[id]/[...slug].astro b/src/pages/series/[id]/[...slug].astro
@@ -4,14 +4,19 @@ import CoverStack from "../../../components/CoverStack.astro";
 import { IssueGrid } from "../../../components/IssueGrid/IssueGrid";
 import { SortButton } from "../../../components/SortButton";
 import { kvGetVolume, kvGetFollowSeries } from "../../../util/kv";
+import { $sort } from "../../../stores/sort.store";
 
 import type { ComicvineVolumeResponse } from "../../../util/comicvine.types";
 
+const sort = Astro.url.searchParams.get("sort") === "asc" ? "asc" : "desc";
+$sort.set(sort);
+
 const kv = Astro.locals.runtime.env.COMICS;
 const { id, slug } = Astro.params;
 let volume: ComicvineVolumeResponse | undefined;
 let currentPage = 1;
 let isFollowing = false;
+
 if (slug) {
   currentPage = parseInt(slug);
 }
@@ -97,4 +102,3 @@ try {
     )
   }
 </Layout>
-../../../util/kv ../../../util/comicvine.types
diff --git a/src/pages/story-arc/[storyArcId].astro b/src/pages/story-arc/[storyArcId].astro
@@ -0,0 +1,2 @@
+---
+---
diff --git a/src/stores/sort.store.ts b/src/stores/sort.store.ts
@@ -1,12 +1,32 @@
-import { persistentAtom } from "@nanostores/persistent";
+import { atom } from "nanostores";
 export type Sort = "asc" | "desc";
 
-export const $sort = persistentAtom<Sort>("sortIssues", "asc");
+function getSortfromURL() {
+  if (typeof document === "undefined") {
+    return "desc";
+  }
+  const url = new URL(document.location.href);
+  const sort = url.searchParams.get("sort");
+
+  if (sort === "asc") {
+    return "asc";
+  }
+  return "desc";
+}
+
+function setSortInURL(sort: Sort) {
+  const url = new URL(document.location.href);
+  url.searchParams.set("sort", sort);
+  history.pushState({}, "", url.href);
+}
+
+export const $sort = atom<Sort>(getSortfromURL());
 
 export function toggleSort(sort: Sort) {
   if (sort === "asc") {
     $sort.set("desc");
   } else {
     $sort.set("asc");
   }
+  setSortInURL($sort.get());
 }
diff --git a/src/util/clampIssuesPerPage.ts b/src/util/clampIssuesPerPage.ts
@@ -0,0 +1,31 @@
+import type { Sort } from "../stores/sort.store";
+import type { ShortIssue } from "./comicvine.types";
+
+export function clampIssuesPerPage({
+  issuesPerPage,
+  currentPage,
+  issueList,
+  sortDirection,
+}: {
+  issuesPerPage: number;
+  currentPage: number;
+  issueList: ShortIssue[];
+  sortDirection: Sort;
+}) {
+  // sort the issues by issue number
+  if (sortDirection === "desc") {
+    issueList.sort(
+      (a, b) => parseInt(b.issue_number) - parseInt(a.issue_number)
+    );
+  } else {
+    issueList.sort(
+      (a, b) => parseInt(a.issue_number) - parseInt(b.issue_number)
+    );
+  }
+  const trimmedList = issueList.slice(
+    (currentPage - 1) * issuesPerPage,
+    currentPage * issuesPerPage
+  );
+
+  return trimmedList;
+}
diff --git a/src/util/kv.ts b/src/util/kv.ts
@@ -67,35 +67,31 @@ export async function kvGetVolume(
     } else {
       const response = await getVolumeDetails(id);
       if (response) {
-        const issuesFromVolume = await kvGetIssuesFromVolume(id, kv);
         let cover_image: string[] = [];
-        if (issuesFromVolume) {
-          cover_image = issuesFromVolume
-            .reverse()
-            .slice(0, 5)
-            .map((issue) => issue.image.medium_url);
 
-          // sort by issue number
-          response.issues.sort(
-            (a, b) => parseInt(a.issue_number) - parseInt(b.issue_number)
-          );
+        // sort by issue number
+        response.issues.sort(
+          (a, b) => parseInt(a.issue_number) - parseInt(b.issue_number)
+        );
 
-          for (const responseIssue of response.issues) {
-            const issue = issuesFromVolume.find(
-              (issue) => issue.id === responseIssue.id
-            );
-            if (issue) {
-              responseIssue.image = issue.image;
-            }
+        const firstFiveIssues = response.issues.slice(0, 5);
+
+        for (const issue of firstFiveIssues) {
+          const issueDetails = await kvGetComicIssue(issue.id, kv);
+          if (issueDetails) {
+            cover_image.push(issueDetails.image.medium_url);
           }
         }
+
         const fullResponse = {
           ...response,
           cover_image,
         };
+
         await kv.put(`4050-${id}`, JSON.stringify(fullResponse), {
           expirationTtl: 60 * 60 * 24 * 7, // 7 days
         });
+
         return fullResponse;
       }
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -82,4 +82,3 @@ const title = data @@
         )
       }
     </Layout>
-    ../../../util/comicvine.types