Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

378 ms triggerstpsas #379

Merged
merged 11 commits into from
Oct 31, 2024
Merged

378 ms triggerstpsas #379

merged 11 commits into from
Oct 31, 2024

Conversation

tmoody
Copy link
Member

@tmoody tmoody commented Oct 30, 2024

Issue

#378

Intent

Here is a macro to call the sasjs api .../stp/trigger endpoint and request that the named job be executed and, optionally, for how long the session folder of that job should be retained beyond the completion of its session (which defaults to 15 minutes). The api returns the sessionid of the initiated job which is recorded by this macro in a SAS dataset.

Implementation

This introduces only new code, based upon the design of ms_runstp.sas. No existing code is changed.

Checks

  • Code is formatted correctly (sasjs lint).
  • Any new functionality has been unit tested.
  • All unit tests are passing (sasjs test).
  • The PR desc or underlying commits follow the Conventional Commit standard

@tmoody tmoody requested a review from allanbowe October 30, 2024 19:35
@tmoody tmoody linked an issue Oct 30, 2024 that may be closed by this pull request
all.sas Show resolved Hide resolved
@tmoody
Copy link
Member Author

tmoody commented Oct 31, 2024

Tests added.

, "test_results":
[
{"TEST_DESCRIPTION":"Testing Scope Leakage" ,"TEST_RESULT":"PASS" ,"TEST_COMMENTS":"GLOBAL Variables Unmodified" }
,{"TEST_DESCRIPTION":"Testing output exists" ,"TEST_RESULT":"PASS" ,"TEST_COMMENTS":"MP_ASSERT: Test result of 1=1" }
,{"TEST_DESCRIPTION":"Testing observations" ,"TEST_RESULT":"PASS" ,"TEST_COMMENTS":"MP_ASSERTDSOBS: Dataset work.mySessions has 2 observations." }
,{"TEST_DESCRIPTION":"Testing column exists" ,"TEST_RESULT":"PASS" ,"TEST_COMMENTS":"MP_ASSERTCOLS: work.mySessions has ALL columns" }
,{"TEST_DESCRIPTION":"Checking final err condition" ,"TEST_RESULT":"PASS" ,"TEST_COMMENTS":"MP_ASSERT: Test result of (0=0)" }
]

server/ms_triggerstp.sas Outdated Show resolved Hide resolved
@tmoody
Copy link
Member Author

tmoody commented Oct 31, 2024

Test results for latest update

"test_results":
[
{"TEST_DESCRIPTION":"Testing Scope Leakage" ,"TEST_RESULT":"PASS" ,"TEST_COMMENTS":"GLOBAL Variables Unmodified" }
,{"TEST_DESCRIPTION":"Testing output exists" ,"TEST_RESULT":"PASS" ,"TEST_COMMENTS":"MP_ASSERT: Test result of 1=1" }
,{"TEST_DESCRIPTION":"Testing observations" ,"TEST_RESULT":"PASS" ,"TEST_COMMENTS":"MP_ASSERTDSOBS: Dataset work.mySessions has 2 observations." }
,{"TEST_DESCRIPTION":"Testing column exists" ,"TEST_RESULT":"PASS" ,"TEST_COMMENTS":"MP_ASSERTCOLS: work.mySessions has ALL columns" }
,{"TEST_DESCRIPTION":"Testing type and content of output" ,"TEST_RESULT":"PASS" ,"TEST_COMMENTS":"MP_ASSERT: Test result of C = C and 1 = 1" }
,{"TEST_DESCRIPTION":"Checking final err condition" ,"TEST_RESULT":"PASS" ,"TEST_COMMENTS":"MP_ASSERT: Test result of (0=0)" }
]

Copy link
Member

@allanbowe allanbowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@allanbowe allanbowe merged commit 2bb1df8 into main Oct 31, 2024
1 check passed
@allanbowe allanbowe deleted the 378-ms_triggerstpsas branch October 31, 2024 18:07
Copy link

🎉 This PR is included in version 4.53.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ms_triggerstp.sas
2 participants