Parse hostname type=user to host_extras #125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value is relevant when dealing with NSE outputs for web oriented services where name-based virtualhosting might apply (nmap/output.cc write_xml_initial_hostinfo).
add new values to the test data
|
btw turns out that it should partialy solve #103 . it does not honor requested xml dtd, but it's backward compatible with current api |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
please consider this PR. The changes adds hostname type="user" from the report to NmapHost.host_extra under "user_target_hostname" key.
Such value is important when working with NSE plugins dealing with web services where name-based virtualhosting might apply. In the nmap's output it is the only field of the host, service or script element where one can find at least weak indication of what the original specified target and NSE target was actually used (simples test cases can be made via http-title.nse where the differences of scanning ip, host or vhost cname are easy to spot).