add optional scroll time parameter #219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
depend on scrollDelay property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responding to #199
Added a property [scrollDelay] in the ScrollableTrimViewer that will switch the hardcoded 300 milliseconds in each of the animations and wait times to this value.
Added an optional input to the parent TrimViewer that will accept a value to be passed along. If no value is given, it will default back to the 300ms.
When dropping the value from 300ms, the trimviewer is quicker to respond to scrolling the timeline and has more of a consistent scroll effect over the delayed and fragmented motions