Merge pull request #484 from scalacenter/ticket/292

Remove "Modified names" assertion
sbt · Jan 22, 2018 · 17a4ba5 · 17a4ba5
2 parents 52b2e9a + 841284e
commit 17a4ba5
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/internal/zinc-core/src/main/scala/sbt/internal/inc/Changes.scala b/internal/zinc-core/src/main/scala/sbt/internal/inc/Changes.scala
@@ -50,9 +50,7 @@ final case class APIChangeDueToMacroDefinition(modified0: String) extends APICha
  * This class is used only when name hashing algorithm is enabled.
  */
 final case class NamesChange(modified0: String, modifiedNames: ModifiedNames)
-    extends APIChange(modified0) {
-  assert(modifiedNames.names.nonEmpty, s"Modified names for $modified0 is empty")
-}
+    extends APIChange(modified0)
 
 /**
  * ModifiedNames are determined by comparing name hashes in two versions of an API representation.

diff --git a/zinc/src/sbt-test/source-dependencies/empty-modified-names/T.scala b/zinc/src/sbt-test/source-dependencies/empty-modified-names/T.scala
@@ -0,0 +1,3 @@
+trait T2
+trait T1 extends T2 { def foo: String }
+class C1 extends T1 { def foo = "test" }
diff --git a/zinc/src/sbt-test/source-dependencies/empty-modified-names/changes/T.scala b/zinc/src/sbt-test/source-dependencies/empty-modified-names/changes/T.scala
@@ -0,0 +1,3 @@
+trait T2 { def foo: String }
+trait T1 extends T2
+class C1 extends T1 { def foo = "test" }
diff --git a/zinc/src/sbt-test/source-dependencies/empty-modified-names/test b/zinc/src/sbt-test/source-dependencies/empty-modified-names/test
@@ -0,0 +1,3 @@
+> compile
+$ copy-file changes/T.scala T.scala
+> compile