This repository has been archived by the owner on Feb 20, 2019. It is now read-only.
Handle sealed classes in check for non-cyclic types #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we should really find a principled approach to dealing with collections. for now, for the sake of performance, I'm leaving this alone and hacking a workaround
that's definitely unwanted on the demo
This also adds Byte and Char tests for binary pickle format.
…acheck Updates scalatest and scalacheck versions
- uses correct existential in FastTypeTag macro - adds source compatibility stubs
Enable cross compilation
Remove obsolete pomPostProcess from build
Introducing incremental picklers, along with a refactoring of the encoding logic of the binary format. - The binary.Util library now contains all encoding functions. - The simpler ArrayOutput[T] replaces EncodedOutput[T]. - The binary pickle format now uses an incremental serialization mechanism. - Added test cases for the encoding/decoding functions of binary.Util. - ByteArrayOutput.put() now throws java.lang.IllegalStateException.
- Remove seemingly arbitrary @inline annotations - Remove unneeded imports
Travis build failures generate too much emails as of late :)
removes myself from the travis config
Incremental Pickling and InputStream Support
Bumping up sbt-pgp to 0.8.3 on 0.9.x branch
- Enable configuring the Scala version used for the build using the 'scala.version' system property. - The default Scala version is 2.11.0 if the system property is not set.
Make Scala version used for build configurable via system property
When deciding to delay the initialization of fields due to possible cycles, sealed classes were not handled. This could cause issues, such as scala#128, where the initialization of a constructor parameter was delayed and thus the parameter was null during the execution of the constructor.
|
Review by @heathermiller |
|
Fixes #128 |
|
It seems that there’s an issue when a subclass has more type parameters than the sealed super class. so, i’m not sure this is ready to go in yet. Might pull in pending discussion! |
|
Ok, it's been a while. What should we do with this one? More discussion? What should happen in a subclass with more type parameters than its superclass? |
|
Closing in favor of #285 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deciding to delay the initialization of fields due to
possible cycles, sealed classes were not handled. This could
cause issues, such as #128, where the initialization of
a constructor parameter was delayed and thus the parameter
was null during the execution of the constructor.