This repository has been archived by the owner on Feb 20, 2019. It is now read-only.
Fix issue in runtime picklers with singleton objects #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| val moduleMirror = mirror.reflectModule(moduleSym) | ||
| def unpickle(tagDontAccess: => FastTypeTag[_], reader: PReader): Any = | ||
| moduleMirror.instance | ||
| } |
There was a problem hiding this comment.
This addition should be discussed, because it is currently not uniform with genPickler.
|
This no longer merges cleanly. What's the status of this PR? |
eed3si9n
force-pushed
the
issue/runtime-singleton
branch
from
53d8b99 to
5193fdc
Compare
|
Is it good to close this? I'm trying to clean up a little bit old PRs 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.