This repository has been archived by the owner on Feb 20, 2019. It is now read-only.
Minor cleanup of FastTypeTag changes to ensure all tag logic goes thr… #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,34 +54,34 @@ class TestScalaSymbols extends FunSuite { | |||
|
|
|||
| test("fieldTypesWithTypeArgs") { | |||
| assert(Compat.varTypes[ParentTag.Foo[String, Int]].toSet == Set( | |||
| "scala.Tuple2[java.lang.String,scala.Int]", "scala.Int" | |||
| "(String, Int)", "Int" | |||
There was a problem hiding this comment.
I feel like the above representation scala.Tuple2[java.lang.String,scala.Int] is more accurate than (String, Int). Is this happening because you're now using toString of the type implementation? I'm not sure if this human-friendly display name should be taken seriously.
There was a problem hiding this comment.
This is literally just a test. The macro is ONLY used to test that symbols are pulled out.
Not meant to be human friendly, so no, it's not meant to be taken seriously. It's only so we can test if things inside the macro are working.
There was a problem hiding this comment.
ok. varTypes is used only for your tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ough new macro.
Follow on from previous.
Review by @phaller or @eed3si9n