Add selfdescribing test #407
Conversation
This test shows a typical concrete use case to instantiate a static pickler from the class name of the unpickler that is serialized along the other information of the pickled instance, so that someone can unpickle this message even if it doesn't know anything about the entity it has to unpickle.
| abstract class SDPicklingLogic extends Ops with AllPicklers with BinaryFormats | ||
|
|
||
| object SDPicklingProtocol extends { | ||
| val ignoreMe = scala.pickling.internal.replaceRuntime(new HybridRuntime) |
There was a problem hiding this comment.
This is problematic, since it makes several other tests break. It appears that it is not necessary anyway for this test.
There was a problem hiding this comment.
It is really necessary that HybridRuntime is enabled, otherwise it will use runtime reflection to unpickle.
There was a problem hiding this comment.
Ah, yeah, you'll have to create anew project to run tests off of. Make the new project depend on "core" and It can have this new protocol.
The issue is, runtime is a "global" so while you can replace it, we'll need different JVMs to test the various runtime options.
It'd be good to have a hybrid test-project anyway, so if you need, I can create it.
There was a problem hiding this comment.
No problem @jsuereth, I'll take over it, thanks 👍
This test shows a typical concrete use case to instantiate a static
pickler from the class name of the unpickler that is serialized along
the other information of the pickled instance, so that someone can
unpickle this message even if it doesn't know anything about the entity
it has to unpickle.