This repository has been archived by the owner on Feb 20, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
structure of the tests that allow fast browsing through the test suite
and it also allow us to distinguish which tests are missing (e.g. tests
that check the binary format but not the json format). Also, an important
point is that this is the first step to port the test suite to Scalajs and
reuse most of its components. For doing that, we're importing
staticOnly
all over the place and therefore we figure out which tests are Scalajs friendly
and which are not.
Disclaimer: the Scalajs restructure will be also done in this PR.
Changes
Add
staticOnly
flag to most of binary testsstill some bad boys that need to be moved to the JVM folder, since they
need reflection somehow.
Group better the tests
logic
togeneration
to store all the tests related with thecorrect generation of picklers for any type.
generator
,pickler
,tags
andinternal
togeneration
.Rename tests to specify their own format
test since some tests are repeated for different formats
(binary and json) with the same test name.
Merge the tests and change the overall structure
structure of the tests that allow fast browsing through the test suite
and it also allow us to distinguish which tests are missing (e.g. tests
that check the binary format but not the json format).
them checks that our picklers are thread-safe in both formats.
do, and therefore they are a little bit more verbose. A little subset
has the name of the test class (and not only the file) changed, but
this is practically unimportant.
to select tests for the scalajs support. That is the next step.
Update scalatest and fix scalatest issue 873
compatible.
assert macro and our generated picklers and unpicklers. The assert
macro is going to cache the condition that is testing and is going to
convert it to a
String
to show it to the user in case of failure.If the condition that is evaluated by assert uses
pickle
andunpickle
and the generated picklers/unpicklers are very big, theysurpass the 65k length limit imposed by the code generators (both in
ScalaJS and the JVM) since they store the length in two bytes.