Add support for specialized tuples #428
Conversation
Now, we support pickling and unpickling specialized tuples. It's necessary to add a special method to check class equality since the specialized classes are implemented as subclasses and therefore have its own class name, failing a simple class equality.
jvican
force-pushed
the
add-specialized-tuple-support
branch
from
9c9af01 to
809db6a
Compare
| /* Map specialized classes to classes. Canonical use case: tuples. | ||
| * We map classes instead of strings to check at runtime that they exist. */ | ||
| val specialMappingClasses: Map[Class[_], Class[_]] = | ||
| mapSpecializedTuplesFor("scala.Tuple2") // add also other special cases |
There was a problem hiding this comment.
We may be able to make this more generic, i forget the rules fo r specialization mangling
There was a problem hiding this comment.
Sure thing! Actually, I'd like to make it more generic, but first i think we should find another compelling use case 😄
There was a problem hiding this comment.
I've found out how specialization mangling works, but i think we shouldn't include it now and wait for a more compelling use case.
|
I love the idea of this and how much cleaner it is! I think it'd be even cleaner if it were in the picklerregistry. |
|
Definitely, thanks for the tip, will do that when i get some time! |
* Reuse code in `RuntimePicklerRegistry` and `sourcegen`. * Create `ClassMapper` to delegate the tasks of checking class equality.
jvican
force-pushed
the
add-specialized-tuple-support
branch
2 times, most recently
from
4e0b03d to
caf8730
Compare
|
This PR has been updated with your suggestions @jsuereth |
| @@ -111,7 +117,8 @@ private[pickling] trait SourceGenerator extends Macro with tags.FastTypeTagMacro | |||
| case Some(b) => | |||
| val parentTpe = x.parent.tpe[c.universe.type](c.universe) | |||
| val impl = generatePickleImplFromAst(b) | |||
| q"""if(classOf[$parentTpe] == picklee.getClass) $impl else $subclasses""" | |||
| val checkIfParent = q"$classMapper.areSameClasses(picklee.getClass, classOf[$parentTpe])" | |||
| q"""if($checkIfParent) $impl else $subclasses""" | |||
There was a problem hiding this comment.
Isn't this already handled in the CaseDef?
There was a problem hiding this comment.
Yes, but they're used for different use cases. The one that solves my problem is this one, but for the sake of correctness I decided to put it in the CaseDef as well. IIRC, this one takes care of the superclass, the case def of the subclasses.
|
One quick question, otherwise LGTM |
Add extendible way to pickle specialized classes
RuntimePicklerRegistryandsourcegen.ClassMapperto delegate the tasks of checking class equality.Add tests for Tuple2 (normal and specialized)
to add a special method to check class equality since the specialized
classes are implemented as subclasses and therefore have its own class
name, failing a simple class equality.