Skip to content
This repository has been archived by the owner on Feb 20, 2019. It is now read-only.

Address fixes pointed out in #419 #430

Merged
merged 2 commits into from
Jun 1, 2016
Merged

Address fixes pointed out in #419 #430

merged 2 commits into from
Jun 1, 2016

Conversation

jvican
Copy link
Member

@jvican jvican commented May 25, 2016

  • Add a new unrecognized tag error.
  • Abstract over NoTypeHint.
  • Fix class keyword repetition in UnrecognizedClass.
  • Mark stack as mutable.

@jvican jvican force-pushed the cleanup-previous-fixes branch 2 times, most recently from abfa03f to 3d85738 Compare May 25, 2016 21:19
jvican added 2 commits May 25, 2016 23:54
@jvican
Address fixes pointed out in scala#419
9b25d24 
* Add a new unrecognized tag error.

* Abstract over `NoTypeHint`.

* Fix `class` keyword repetition in `UnrecognizedClass`.

* Mark stack as mutable.
@jvican
Change visibility of HasCompat
ad9bd99 
* Some parts of the code access this object from somewhere else in
  pickling and visibility has to be updated accordingly.
@jvican jvican force-pushed the cleanup-previous-fixes branch from 3d85738 to ad9bd99 Compare May 25, 2016 21:57
@jvican
Copy link
Member Author

jvican commented Jun 1, 2016

Can you review this @jsuereth ?

@jsuereth jsuereth merged commit 34a641d into scala:0.11.x Jun 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jvican @jsuereth @heathermiller