This repository has been archived by the owner on Feb 20, 2019. It is now read-only.
Add pickler and unpickler for Nothing #433
Merged
+44
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add picklers for Nothing, `pickle` cannot be actually called. Reuse `FastTypeTag[Nothing]`, which was already defined. Include the picklers in `Defaults`. * Add error in case the `unpickle` method is called. * Remove annoying println in test `NullBinaryTest`.
| @@ -178,4 +178,8 @@ object PicklingErrors { | |||
| final case class Wrapper(e: Throwable, msg: String, delimiter: String = "\n") | |||
| extends BasePicklingException(s"$msg$delimiter${e.getMessage}", Some(e)) | |||
|
|
|||
| /** Exception thrown when one tries to unpickle on a Unpickler[Nothing]. */ | |||
| case object NothingIsNotUnpicklable extends PicklingRuntimeException( | |||
| s"You called `unpickle` on `Unpickler[Nothing]`, but it cannot be unpickled") | |||
There was a problem hiding this comment.
So we're throwing an exception, so you know we returned nothing :)
|
So besides the fact I think we should try to statically catch piclking nothign and issue an error, this looks good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
picklecannot be actually called. ReuseFastTypeTag[Nothing], which was already defined. Include thepicklers in
Defaults.unpicklemethod is called.NullBinaryTest.