Skip to content
This repository has been archived by the owner on Feb 20, 2019. It is now read-only.

[WIP] Support for Scala 2.12 #438

Closed
wants to merge 2 commits into from
Closed

[WIP] Support for Scala 2.12 #438

wants to merge 2 commits into from

Conversation

jodersky
Copy link

Mainly just copy over the sun.misc.Unsafe, as it is not made available through Scala concurrent anymore.
Compilation is fine, however anonymous functions currently don't work as these are no longer built as Class$$anonfun$ classes (hence the WIP tag).

This is a continuation of the discussion in #388.

@unoexperto
Copy link

@jodersky How is it going ?

I tried compiling your branch with 2.12-M5 and get this

[error] /home/expert/work/externals/pickling/core/src/main/scala/scala/pickling/generator/sourcegen.scala:7: type FastTypeTagMacros is not a member of package scala.pickling.tags
[error] private[pickling] trait SourceGenerator extends Macro with tags.FastTypeTagMacros {
[error]                                                                 ^
[error] /home/expert/work/externals/pickling/core/src/main/scala/scala/pickling/generator/sourcegen.scala:7: type FastTypeTagMacros is not a member of package scala.pickling.tags
[error] private[pickling] trait SourceGenerator extends Macro with tags.FastTypeTagMacros {
[error]                                                                 ^
[error] /home/expert/work/externals/pickling/core/src/main/scala/scala/pickling/generator/sourcegen.scala:337: not found: value typeKey
[error]          val skey = typeKey(stpe)
[error]                     ^
[error] /home/expert/work/externals/pickling/core/src/main/scala/scala/pickling/generator/sourcegen.scala:419: FastTypeTagMacros does not name a parent class of trait SourceGenerator
[error]     val createTagTree = super[FastTypeTagMacros].impl[T]
[error]                         ^
[error] /home/expert/work/externals/pickling/core/src/main/scala/scala/pickling/generator/sourcegen.scala:337: not found: value typeKey
[error]          val skey = typeKey(stpe)
[error]                     ^
[error] /home/expert/work/externals/pickling/core/src/main/scala/scala/pickling/generator/sourcegen.scala:419: FastTypeTagMacros does not name a parent class of trait SourceGenerator
[error]     val createTagTree = super[FastTypeTagMacros].impl[T]
[error]                         ^
[error] /home/expert/work/externals/pickling/core/src/main/scala/scala/pickling/tags/Compat.scala:11: not found: type FastTypeTagMacros
[error]     val bundle = new { val c: c0.type = c0 } with FastTypeTagMacros
[error]                                                   ^
[error] /home/expert/work/externals/pickling/core/src/main/scala/scala/pickling/tags/Compat.scala:11: not found: type FastTypeTagMacros
[error]     val bundle = new { val c: c0.type = c0 } with FastTypeTagMacros
[error]                                                   ^

@jodersky
Copy link
Author

Hi @CPPExpert, that looks very strange. As you can see in the diff, essentially all my changes consist of copying the unsafe code to scala pickling.

Could your build environment be dirty?

@ekrich
Copy link

ekrich commented Jun 2, 2017

I have submitted a PR as well - I also got rid of most of the deprecations but also removed 2.10 support. Refer to #451 for more info.

@jodersky
Copy link
Author

Superseded by #451

@jodersky jodersky closed this Mar 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants